ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
229 stars 398 forks source link

[CODE] Create s_c2 for patrols #2534

Open tobes03 opened 3 days ago

tobes03 commented 3 days ago

By request -- It would open up many more possibilities for writing patrols if another "s_c" were created for patrols.

Currently, "s_c" allows writers to make outcomes specific to particular traits. A creation of a separate "s_c2" option for patrols would allow for outcomes based on two cats with different (or identical) skills and traits interacting on the basis of those skills/traits.

The current lists for s_c look like these: "stat_skill": [], "stat_trait": [], "can_have_stat": [],

I'm imagining something like: "stat_skill": [], "stat_trait": [], "can_have_stat": [], "stat_skill_two": [], "stat_trait_two": [], "can_have_stat_two": [],

If there's a more elegant or efficient way to do that, then all the better. Instead of just having outcomes like "s_c is grumpy." we could also have outcomes like "s_c is grumpy but their charismatic Clanmate s_c2 always cheers them up."

scribblecrumb commented 3 days ago

Possibly a better way to structure this would be something akin to the new_cat blocks, though as a list of dicts rather than list of lists. Could try something like:

"stat_cat": [
   {
      "stat_skill": [],
      "stat_trait": [],
      "can_have_stat": []
   }
]

Thus, each additional dict within the list becomes a new stat cat and could follow the same naming convention as new_cats (i.e. s_c{index}). This could even open up the possibility of more than just 2 stat cats, though I'm not sure how that idea would actually mesh within the patrol cat assigning code. Regardless, I think this would be more consistent with our established patrol structure and would allow for easier extension in the future.

DeadGirlRisen commented 3 days ago

Me and Tiri have a whole list of things we want, and we have a rough plan, so hopefully this is something that can be worked on soon. Not saying I'm taking this on for sure, but that its in the scope of something similiar. (I apoligize if Im not making sense)