ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
241 stars 432 forks source link

[BUG] gen_death_trapmurder1 gives no cause of death in a cat's history #2556

Open blackkat312 opened 2 months ago

blackkat312 commented 2 months ago

Type:

Describe the bug If a cat is murdered in the event "gen_death_trapmurder1", they will be given no cause of death in their history. This is due to an extra colon in the history section of the event itself.

Grade:

Reproduce Steps to reproduce the behavior:

  1. Go to game_config and set debug_ensure_event_id to "gen_death_trapmurder1", and base_random_murder_chance to 1.
  2. Open ClanGen and moonskip until you get the event.
  3. Go to the victim's profile and open their history tab.
  4. Cat will have no cause of death.

Commit # or Game Version Number: https://github.com/ClanGenOfficial/clangen/commit/dd218d29bf5d5c86a13ffd8dac9fa14e67643789

Screenshots Getting murder event Death_text_bug2

Lack of death text Death_text_bug3

History comparison with a correctly working murder event Death_text_bug4

And the extra colon that's causing the bug! Death_text_bug1

blackkat312 commented 1 month ago

After someone noticed gen_death_angrymurder1 also not giving a cause of death, I looked and the following death events also have the extra colon:

j-gynn commented 1 week ago

/assign-me

github-actions[bot] commented 1 week ago

👋 Hey @j-gynn, thanks for your interest in this issue! 🎉

âš  Note that this issue will become unassigned if it isn't closed within 7 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.