[BUG] History crash

[LaurelWillow]

Type: (only select one)

• Code - general bugs related to how the game runs and responds to you.

Describe the bug One of my cats just really likes to crash the game when I try to look at his history. I've crashed my game like seven times trying to figure out what exactly is going on. I originally thought it was crashing because he died saving a cat who has now faded. However, on a different clan, save file editing in the same death and fading a cat, it didn't crash, so now I'm not sure.

Grade:

• Game-breaking - a bug that makes it impossible to play the game

Reproduce I don't actually know. If I definitively figure out what's causing this, I'll update this section to reflect that.

Commit # or Game Version Number: cfcf13b8

Additional context This was originally reported by ServalBones on discord, who had a similar crash specifically when turning on the "view moon" setting in a murdered cat's history. While trying to reproduce it, I got this crash, which I think is slightly different but I'm not completely sure.

Screenshots crasher of games:

crasher of games' history file:

crash log:

ServalBones' original bug report:

History file from that cat:

crash log:

[PoppyBlossom]

Thank you for opening this issue. From the crash log you provided it seems like it's trying to get the r_c(random cat)'s pronoun but failed, I assume the choice function received null which caused the crash. I'm going to try recreating the crash.

[PoppyBlossom]

In cfcf13b when a cat fades it sets its pronoun to an empty array (script/cat/cats.py line 371) which explains the 'cannot choose from an empty sequence' part of the crash log.

[ZtheCorgi]

none pronouns with left crash....

[PoppyBlossom]

Here's a breakdown of the problem

1. cat faded, script/game_structrue, line 476 creates a simplified version of the cat's info, which has an empty array for pronouns
2. trying to read the faded cat's pronoun information using the function choice in script/utility, line 2005, which resulted in a crash.

possible fix: there is no simple way around this unless changing the way the faded cat's info is preserved. Or we can use gender-neutral pronouns, it's better than crashing.

[PoppyBlossom]

I managed to replicate this crash. Follow these steps: Find a cat and modify the "die_by, text" in its history file to something like "m_c died of old age because of r_c." Make sure to specify an ID of a faded cat from the "faded_cats" folder in the "involve" field. After making these changes, run the game and check the cat's history. The game will crash as a result.

[PoppyBlossom]

@LaurelWillow thank you for the infomations! If you don't mind you can make ServalBones's bug report a separate issue since they are quite different.

[LaurelWillow]

Yup I can do that! Thankful my guy Fincrest will no longer be a gamebreak hazard 👍