ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
251 stars 450 forks source link

Switch Run Scripts To Use python3 #2596

Closed Sumwatt0 closed 2 months ago

Sumwatt0 commented 2 months ago

About The Pull Request

Switches run scripts from using python to using python3.

Why This Is Good For ClanGen

python points to python2 on many systems, and even where it doesn't, using python3 is more explicit, clear and safe.

Proof of Testing

Screenshot 2024-07-29 at 1 38 16 PM

It opens clangen like normal.

Changelog/Credits

[ENHANCEMENT]: Run scripts now use python3

Credit: (Sumwatt/Sumwatt0)

archanyhm commented 2 months ago

While the reasoning is technically correct in regular python contexts, the run scripts utilise poetry which sets both python and python3 — if applicable — to the version the configured environment uses. Therefore, there's no real benefit to explicitly call python3.

Poetry also omits the 3 in their basic usage documentation found here: https://python-poetry.org/docs/basic-usage/#using-poetry-run

Sumwatt0 commented 2 months ago

That makes sense, I guess I'm just hardwired into using python3 every time lol.