ClanGenOfficial / clangen

Warrior Cats fan game
https://clangen.io
Other
269 stars 481 forks source link

Fix comparison in possible_lead_den_events for status='former ClanCat' #3057

Closed bakermor closed 2 days ago

bakermor commented 3 days ago

About The Pull Request

In possible_lead_den_events there is a comparison between the cat's status.casefold() ("former clancat") and the event's allowed statuses ("former Clancat") which prevents the event from being added to possible_events.

Linked Issues

Fixes #3056 Also references PR #3025

Proof of Testing

image Failure Outcome: image Success Outcome: image

Generated Events Before: image Generated Events After: image

Changelog/Credits

j-gynn commented 3 days ago

oh. *screams internally that somehow that slipped past me* at least it's not my worst clangen nonsense i've ever pushed to main...!

scribblecrumb commented 2 days ago

Thanks for the bugfix! Are you part of our discord server? If you'd like and if you plan to continue contributing, you're eligible to receive dev roles there and access the dev channels. It's not a requirement, though! And if you're welcome to continue contributing without being on the discord.