search

Clancey / FlyoutNavigation

Other
95 stars 87 forks source link

wrong behaviour when starting in landscape mode #10

Closed mvidmar closed 9 years ago

mvidmar commented 11 years ago

When starting in landscape mode on the ipad, the menu is hidden and the swiping doesn't work correctly.

It should work when the following are added to ViewWillAppear if (this.ShouldStayOpen && !this.IsOpen) { ShowMenu(); }

ghost commented 11 years ago

I noticed this too. It even happens in the sample application. However, I noticed that it does not seem to matter if it starts in landscape or if is rotated to landscape it just doesn't work correctly once it ends up in landscape mode.

ghost commented 11 years ago

More specifically if you toggle the menu open in landscape on an iPad it does not close the menu on selection, and it does not repaint the right hand side of the screen if you close it manually.

ghost commented 11 years ago

So I did more debugging through the code and found that it works okay as long as you set AlwaysShowLandscapeMenu = false (the default is true). If it is set to true then it does not work right if you toggle the menu.

Clancey commented 11 years ago

That makes sense, I have it set to false in my one app. Thats why I have never seen it.

James Clancey

On Monday, June 17, 2013 at 10:13 PM, bjdawson wrote:

So I did more debugging through the code and found that it works okay as long as you set AlwaysShowLandscapeMenu = false (the default is true). If it is set to true then it does not work right if you toggle the menu.

— Reply to this email directly or view it on GitHub (https://github.com/Clancey/FlyoutNavigation/issues/10#issuecomment-19591291).

ghost commented 11 years ago

It should probably be changed to ignore ToggleMenu when on an iPad, in landscape, and AlwaysShowLandscapeMenu == true.