search

Clancey / FlyoutNavigation

Other
95 stars 87 forks source link

view.Subviews == null during recursive ResignFirstResponders causing crash #27

Closed benhysell closed 11 years ago

benhysell commented 11 years ago

Added a null check to prevent crashing on latest iOS and Xamarin builds

Clancey commented 11 years ago

Do you have a use case for this? Subviews should never be null.

benhysell commented 11 years ago

I didn't think they were ever null either, except latest alpha of xamarin with Xcode dp3 crashes without the added null check.

-ben

On Jul 10, 2013, at 10:39 PM, James Clancey notifications@github.com wrote:

Do you have a use case for this? Subviews should never be null.

— Reply to this email directly or view it on GitHubhttps://github.com/Clancey/FlyoutNavigation/pull/27#issuecomment-20786787 .

SmartyP commented 11 years ago

Yeah, I ran into this in some of my own code. In iOS 7 Beta 3 View.Subviews can sometimes be null. Xamarin has already been addressing it, see: https://bugzilla.xamarin.com/show_bug.cgi?id=13119

Clancey commented 11 years ago

This is going to be fixed with the next alpha. So no need for the patch to be commited long term.

Clancey commented 11 years ago

Thanks for the pull request though!

benhysell commented 11 years ago

You are welcome! Sorry I didn't see this was a bug with the alpha.