search

Clancey / FlyoutNavigation

Other
95 stars 87 forks source link

Fixed a bug introduced with iOS 7 that caused the top panel to not follo... #34

Closed jonnynezbo closed 11 years ago

jonnynezbo commented 11 years ago

...w your finger when panning.

Clancey commented 11 years ago

So does this make it to where the menu always works? AKA disabled the swipe to go back?

James Clancey

On Tuesday, August 27, 2013 at 9:26 PM, Jonathan Nesbitt wrote:

...w your finger when panning. You can merge this Pull Request by running git pull https://github.com/jonnynezbo/FlyoutNavigation master Or view, comment on, or merge it at: https://github.com/Clancey/FlyoutNavigation/pull/34 Commit Summary Fixed a bug introduced with iOS 7 that caused the top panel to not follow your finger when panning.

File Changes M FlyoutNavigation/FlyoutNavigationController.cs (https://github.com/Clancey/FlyoutNavigation/pull/34/files#diff-0) (4) M FlyoutNavigation/OpenMenuGestureRecognizer.cs (https://github.com/Clancey/FlyoutNavigation/pull/34/files#diff-1) (8)

Patch Links: https://github.com/Clancey/FlyoutNavigation/pull/34.patch https://github.com/Clancey/FlyoutNavigation/pull/34.diff

jonnynezbo commented 11 years ago

We chatted about it on twitter earlier today. Basically, the top panel did not follow the user's finger when running on iOS 7 beta. This seems to fix that problem without requiring any code changes outside of the FlyoutNavigation library.

The top panel still does not follow the user's finger when closing the flyout menu. Although, I do want to add that feature (see the Facebook app).

Clancey commented 11 years ago

I remember talking about it on twitter, I am just wondering about this behavior:

Your content is a UINavigationController. You push to your second or third screen in. If you swipe, does it navigate back to the previous screen or show the menu?

James Clancey

On Tuesday, August 27, 2013 at 10:32 PM, Jonathan Nesbitt wrote:

We chatted about it on twitter earlier today. Basically, the top panel did not follow the user's finger when running on iOS 7 beta. This seems to fix that problem without requiring any code changes outside of the FlyoutNavigation library. The top panel still does not follow the user's finger when closing the flyout menu. Although, I do want to add that feature (see the Facebook app).

— Reply to this email directly or view it on GitHub (https://github.com/Clancey/FlyoutNavigation/pull/34#issuecomment-23392468).

jonnynezbo commented 11 years ago

When running on iOS 6, even after pushing to your second or third screen in, the swipe would show the flyout menu (not navigate back to the previous screen). Although, we probably do want to allow the developer to override that functionality and allow swipe right to go back to the previous screen (not show the menu) when a the content is a UINavigationController. Let me play around with it more and make sure it is extensible.

Clancey commented 11 years ago

I have already fixed this at the UINavigationController level, as I explained on twitter. I will update the samples to show hows its done. I also think I can just work the fix into Flyout instead.

James Clancey

On Tuesday, August 27, 2013 at 11:07 PM, Jonathan Nesbitt wrote:

When running on iOS 6, even after pushing to your second or third screen in, the swipe would show the flyout menu (not navigate back to the previous screen). Although, we probably do want to allow the developer to override that functionality and allow swipe right to go back to the previous screen (not show the menu) when a the content is a UINavigationController. Let me play around with it more and make sure it is extensible.

— Reply to this email directly or view it on GitHub (https://github.com/Clancey/FlyoutNavigation/pull/34#issuecomment-23393359).

jonnynezbo commented 11 years ago

Sounds good.