Clancey / FlyoutNavigation

Other
95 stars 87 forks source link

New feature: navigation position #44

Closed chr1gu closed 10 years ago

chr1gu commented 10 years ago

I fixed some things:

and I added a new feature:

Best, Chrigu

androidcn commented 10 years ago

Great that's what i need

androidcn commented 10 years ago

but i want two sides like facebook

chr1gu commented 10 years ago

Yes, totally agree that the option to specify two navigations (like Facebook) would be great. I think for this, some parts need to be re-written but I'm still quite new to Xamarin and don't want to messup the project. I first want to see if this PR even gets approved ;)

androidcn commented 10 years ago

Thankyou

在 2013年12月19日星期四,chrigu-ebert 写道:

Yes, totally agree that the option to specify two navigations (like Facebook) would be great. I think for this, some parts need to be re-written but I'm still quite new to Xamarin and don't want to messup the project. I first want to see if this PR even gets approved ;)

— Reply to this email directly or view it on GitHubhttps://github.com/Clancey/FlyoutNavigation/pull/44#issuecomment-30914235 .

Clancey commented 10 years ago

It looks good aside from a lot of formatting changes/white space noise. That just makes it harder to track what really changed. Try to keep those on separate commits.

As far as the MT.D reference, its correct. I use the one from my github repo rather then the built in one. I keep the reference to it.

chr1gu commented 10 years ago

Thanks Clancey and sorry for the formating changes, I'll keep this in mind the next time