search

Clancey / SimpleAuth

The Simplest way to Authenticate and make Rest API calls in .Net
Apache License 2.0
171 stars 48 forks source link

WebAuthenticatorWindow in iOS 13 is displayed as pageSheet #105

Open munkii opened 4 years ago

munkii commented 4 years ago

The WebAuthenticatorWindow that is used by WebAuthenticator from the FitBitApi provider does not allow the customisation of the ViewController or more specifically the ModalPresentationStyle.

In iOS 13 Apple changed the default presentation style for Modal views to be PageSheet from FullScreen. This affects the way Modal pages are dismissed and in Xamarin Forms that causes issues with ViewIsAppearing\ViewIsDisappearing events.

If the WebAuthenticatorWindow is dismissed by simply swiping down the Navigation Stack in XF becomes broken, the page now being is playing cannot be exited and the app needs restarting.

Clancey commented 4 years ago

You have complete control over presenting the UI https://github.com/Clancey/SimpleAuth#webview-authentication

munkii commented 4 years ago

Geez, despite wandering all over the the code in GitHub I could not see this. Thanks