Clancey / vscode-comet

Other
31 stars 11 forks source link

`execa is not a function` when picking device #36

Closed yunusefendi52 closed 2 years ago

yunusefendi52 commented 2 years ago

It seems there is a problem when importing execa, I tried modify extension.js to import execa properly before: const execa = __webpack_require__(/*! execa */ "./node_modules/execa/index.js"); to: const execa = __webpack_require__(/*! execa */ "./node_modules/execa/index.js").execa;

added .execa at the end for workaround

I use v0.7.0 and on mac

Ghostbird commented 2 years ago

Have the same issue. It occurs to me that in the package.json both @types/execa and execa are listed. When I NPM install that, it warns that @types/execa is a stub that should not be used. Could it be that something went wrong because of that?

A direct import of execa does not return a callable function.

jessejiang0214 commented 2 years ago

Fixed in this PR https://github.com/Clancey/vscode-comet/pull/37

Redth commented 2 years ago

Give this build a try: https://github.com/Clancey/vscode-comet/actions/runs/3519810694#artifacts

Not entirely sure what was going on there but this is working locally now for me.

yunusefendi52 commented 2 years ago

tried using latest commit, it's fixed now. thanks!