search

ClangBuiltLinux / ClangBuiltLinux.github.io

A repo that hosts a static site on github pages
https://ClangBuiltLinux.github.io
7 stars 5 forks source link

remove build status #56

Closed nickdesaulniers closed 6 months ago

nickdesaulniers commented 10 months ago

Speculation: It seems recently that github has been rate limiting requests to github.com workflow badge svg files from non-github.com URLs.

Sadly, this seems to include github.io pages, too, which smells like an oversight to me.

What this means in practice is that our homepage looks like hot dogshit full of broken links vs the github page.

Compare https://clangbuiltlinux.github.io/ vs https://github.com/ClangBuiltLinux/continuous-integration2/#readme

The latter is much better looking (no broken embedded images) than the former (many broken embedded images).

It's sad that this is necessary, but I think it will help the home page look more professional. It will also be one less thing to update when we update the matrix using markdown-badges.py.

JustinStitt commented 10 months ago

Can you upload an artifact of what you're seeing, @nickdesaulniers ?

I see a pleasant home page on my end.

image

Granted, I don't check the home page very often -- Are you seeing problems only every once in awhile?

nickdesaulniers commented 10 months ago

image

JustinStitt commented 10 months ago

I can't get the broken page to appear even with lots of refreshes and private tabs + clearing cache. If this is an issue for others though then this change is good.

nickdesaulniers commented 10 months ago

gah, the github.com page cuts off the content and is very difficult to scroll!

image

JustinStitt commented 10 months ago

Are there any large github projects with similar matrices that we can steal the formatting from?

I really like: https://linux.kernelci.org/job/ (not github though)

nickdesaulniers commented 10 months ago

I have filed a bug against github support: https://support.github.com/ticket/personal/0/2313412 (probably not publicly accessible).

JustinStitt commented 10 months ago

Is this at all related to whatever the heck a webhook is: https://www.githubstatus.com/incidents/f7lz4nc72bvp

kees commented 10 months ago

Unfortunately, I think this is the right solution until github fixes their ACLs. I wonder if I could host something to cache the results? I could put it somewhere on .outflux.net ....

JustinStitt commented 10 months ago

Unfortunately, I think this is the right solution until github fixes their ACLs. I wonder if I could host something to cache the results? I could put it somewhere on .outflux.net ....

I wonder if we can show some aggregate statistic like "Passing Builds 24/36" or something like that -- then also provide a link to the readme matrix.

I propose this aggregate statistic could be generated through a workflow itself, then the main githubio page needs to just make a single call to this single badge.

nathanchance commented 10 months ago

Just as a data point, I see the same problem in Safari:

image
nickdesaulniers commented 9 months ago

@nathanchance

Just as a data point, I see the same problem in Safari:

Was that on clangbuiltlinux.github.io, or https://github.com/ClangBuiltLinux/continuous-integration2#readme ?

nathanchance commented 9 months ago

@nathanchance

Just as a data point, I see the same problem in Safari:

Was that on clangbuiltlinux.github.io, or https://github.com/ClangBuiltLinux/continuous-integration2#readme ?

clangbuiltlinux.github.io, continuous-integration2's has always worked for me.

nickdesaulniers commented 9 months ago

I wonder if we can show some aggregate statistic like "Passing Builds 24/36" or something like that -- then also provide a link to the readme matrix.

Maybe worth researching shields.io. https://github.com/badges/shields

nickdesaulniers commented 9 months ago

I have filed a bug against github support: https://support.github.com/ticket/personal/0/2313412 (probably not publicly accessible).

oh, I did receive a response back on aug 30:

Hi Nick, Thank you for getting in touch with GitHub Support! As GitHub Pages are publicly accessible, GitHub does not process authentication when people visit one of these pages, meaning GitHub Pages sites are subject to the same rate limits as any other GitHub.com page when visited by an unauthenticated user. The result of this is the same as if you were to view your repository page while not logged in, some of the badges do not load as the rate limit is reached. As this is a site-wide rate limit we are unable to change the limit for your GitHub Pages site. You might consider breaking your website up into subdirectories divided by your current headers, this way each section would get a chance to load independently without hitting the rate limit. I hope this clears things up, please let me know if you have any further questions!

JustinStitt commented 6 months ago

Closing this as it was fixed by @kees ' efforts here: https://github.com/ClangBuiltLinux/continuous-integration2/pull/678