search

ClangBuiltLinux / boot-utils

Collection of files for booting Linux kernels
26 stars 7 forks source link

boot-uml.py requires full path. #103

Closed nickdesaulniers closed 1 year ago

nickdesaulniers commented 1 year ago

I noticed that

$ /android1/boot-utils/boot-uml.py -k /android0/kernel-all/linux
<works>
$ /android1/boot-utils/boot-uml.py -k .
$ linux ubd0=/android1/boot-utils/images/x86_64/rootfs.ext4
Traceback (most recent call last):
  File "/android1/boot-utils/boot-uml.py", line 82, in <module>
    run_kernel(kernel, decomp_rootfs(), args.interactive)
  File "/android1/boot-utils/boot-uml.py", line 75, in run_kernel
    subprocess.run(uml_cmd, check=True)
  File "/usr/lib/python3.10/subprocess.py", line 503, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1847, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: PosixPath('linux')

I usually use -k . with boot-qemu.py but this seems to produce the FileNotFoundError with boot-uml.py. Maybe there's some path searching code that can be moved to utils.py and reused between the two?