Closed nathanchance closed 5 years ago
All comments should be addressed. If no ${CC}
or ${AR}
is found, the version command will now properly fail because we set -e
at the top.
I went ahead and added a more descriptive message if clang
is not found (or if the user specified a non-existent binary in PATH).
We've tailored driver.sh around our Docker image with regards to the binary versions that we check for. A user might not have the latest versions of Clang or llvm-ar installed. Check for all three versions offered by apt.llvm.org, falling back to the generic binary name if those are not found.
Additionally, for llvm-ar, do a sanity check that the user has a version of llvm-ar that can actually build the kernel (has support for the P modifier). If they don't fall back to regular GNU ar and let them know.
Presubmit: https://travis-ci.com/nathanchance/continuous-integration/builds/103470578