Closed nathanchance closed 5 years ago
sorry, now that asm goto has landed, can't/shouldn't we just drop all of patches via merging #171
Yes, we should; however, apt.llvm.org's clang hasn't been updated for over a week at this point (almost two). I haven't made a big deal of it because asm goto was still in the works but now that it has landed (and hopefully sticks), we should remove all of our hacks.
I think that this can be merged now then once clang has been updated, we merged #171. Additionally, we need to think about #167 when merging #171.
Thanks for the review!
The compiler.h patch has been merged 1.
To avoid arch/x86/boot/ warnings with clang, I backported Masahiro's JUMP_LABEL and CC_HAS_ASM_GOTO refactoring 2, which causes conflicts in our out of tree patch. We can now use the same patch as mainline (which will include the improvement from #119), which we will hopefully be able to drop soon!