Open tpimh opened 4 years ago
I suppose this would be okay but it is helpful to have set -x
around in case people decide to use this locally and they report bugs to us. I'm fine either way though.
I agree that we can probably hide more things, but some parts are important to have in the output to debug when something goes wrong available in the CI logs. If you have specific sections that you think could be silenced, please call them out and let's discuss if set +x
could be applied to those sections.
Yeah,
set -x
is cool, but maybe it should be hidden behind an extra command line option (like--debug
). Asdriver.sh
gets bigger and more complicated, more output is produced and in most cases it's unnecessary unless you are debuggingdriver.sh
itself. I suggest only producing important information by default: versions of all utilities used, kernel version being built and a list of patches applied. Anything to add to this list?