search

ClapeyronThermo / Clapeyron.jl

Clapeyron provides a framework for the development and use of fluid-thermodynamic models, including SAFT, cubic, activity, multi-parameter, and COSMO-SAC.
MIT License
198 stars 51 forks source link

Method overloading when registering new model #161

Closed moesphere closed 1 year ago

moesphere commented 1 year ago

Related to this issue, when @registermodel is used, method overloading for private functions of Clapeyron must specfiy the Clapeyron namespace.

For example, in this line inside the macro definition, the content must be changed from

:(molecular_weight(model::$model,z=SA[1.0]) =comp_molecular_weight(mw(model),z))

to

:(Clapeyron.molecular_weight(model::$model,z=SA[1.0]) = Clapeyron.comp_molecular_weight(Clapeyron.mw(model),z))
longemen3000 commented 1 year ago

haah, you are helping me debug all this, thank you for that

longemen3000 commented 1 year ago

closed in 0.4.9

moesphere commented 1 year ago

haah, you are helping me debug all this, thank you for that

Nothing compared with the development of this great package by you and your collaborators. 👍