search

ClapeyronThermo / Clapeyron.jl

Clapeyron provides a framework for the development and use of fluid-thermodynamic models, including SAFT, cubic, activity, multi-parameter, and COSMO-SAC.
MIT License
198 stars 51 forks source link

EOS-CG 2021 #233

Closed pw0908 closed 6 months ago

pw0908 commented 10 months ago

Multiparameter equation for CCS applications: https://link.springer.com/article/10.1007/s10765-023-03263-6

ianhbell commented 9 months ago

In that vein, you might want to also add the GERG-2008 model for natural gas. I just added it to teqp: https://github.com/usnistgov/teqp/pull/79

longemen3000 commented 9 months ago

GERG2008 is already in Clapeyron (GERG2008), it uses the same general infraestructure as the multiparameter fluids (with an addon for the difference in R)

ianhbell commented 9 months ago

@longemen3000 Ah cool, didn't realize that.

longemen3000 commented 6 months ago

implemented in 0.5.11

ianhbell commented 6 months ago

Nice! Did you implement test values to be sure all the models are exactly the same?

longemen3000 commented 6 months ago

Not yet, I couldn't find test values of EOS-CG-2021 in the original paper. But on the code part, it just reuses the general MultiFluid code, so the only test necessary is that the data values stored in the database are correct

On the data part, for the pure fluid, the fluids are taken from CoolProp JSONs or ported via REFPROP-interop. On the mixture models, I reused the existing ones where available (from EOS-LNG + some Coolprop mixture models), except the one with typos in the publication, that I have to extract from the paper itself(I have a function that generates mixture jsons from paper tables, so it is not completely manual).

ianhbell commented 6 months ago

One key point is to make sure that you are definitely, 100%, using the pure fluid models that are specified in the document.