ClapeyronThermo / Clapeyron.jl

Clapeyron provides a framework for the development and use of fluid-thermodynamic models, including SAFT, cubic, activity, multi-parameter, and COSMO-SAC.
MIT License
198 stars 51 forks source link

Add vol0 keyword argument to bulk properties #247

Closed Liozou closed 9 months ago

Liozou commented 9 months ago

This PR documents the vol0 keyword argument of volume. It also adds that same keyword argument to all bulk properties that implicitly call volume in order to pass it along, similar to threaded and phase.

I also added a test that fails when the vol0 keyword is not given, to illustrate a typical use-case.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e8d0646) 79.94% compared to head (c193447) 79.97%.

Files Patch % Lines
src/methods/pT.jl 91.04% 6 Missing :warning:
src/models/CompositeModel/FluidCorrelation.jl 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## ========================================== + Coverage 79.94% 79.97% +0.02% ========================================== Files 279 279 Lines 19484 19483 -1 ========================================== + Hits 15577 15581 +4 + Misses 3907 3902 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.