Closed longemen3000 closed 1 month ago
Attention: Patch coverage is 79.96604%
with 118 lines
in your changes missing coverage. Please review.
Project coverage is 76.86%. Comparing base (
878c810
) to head (92fd3d3
). Report is 24 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
this PR:
saturation_pressure(PCSAFT("water"),373.15)
. In multicomponent equilibria, there is a problem with just equating the chemical potentials: the ideal term is of the formf(T) + log(x[i]/v[i])
and their substraction causes numerical problems. combining the two logarithms in one expression seems to stabilize the solver.p_scale
that useslb_volume
andT_scale
. fixes some scaling errors found withp_scale
methods for some EoS.EoSPhase
as a potential struct to use for representing phases (the infraestructure to use it across the methods is not yet there, probably we can use a macro to transform between our current methods return type and returning lists of phases)