Fixed email truncation issues, made a confirm page, made clans and made ...

[ranneyd]

...adjustable brain numbers

[jthemphill]

Everything looks pretty good overall. I'll run a new build against this later tonight to make sure we can still build the site in one step (and test for edge cases).

There's supposed to be a south migration for existing users, right?

[ranneyd]

1) Will do 2) We basically both did the exact same thing by the look of it. His page is less minimalist than mine but JT signed off on mine so I'd like to just go with it 3 (and 7) ) So what they want is this concept of "brain bucks". Basically every time you feed you get a brain and you can spend them on upgrades and the Mods can go in and add and remove brain bucks. Plus you can transfer them to other players if you want. So the number of meals and the number of brains isn't always the same. Also the clan settings and brain incrementation can totally be put in Meal.save(). I agree that that makes more sense 4) will do 5) will remove 6) Good point. Will be fine for now since a new user is made every game but they want to have persistent users in the future so I'll fix that 8) We need to run python manage.py migrate longerusernameandemail to update the user model. Then the 30 character thing will be no problem.

Do you need me to make these changes before you test it tonight?

On Wed, Aug 27, 2014 at 3:11 PM, Jeff Hemphill notifications@github.com wrote:

Everything looks pretty good overall. I'll run a new build against this later tonight to make sure we can still build the site in one step (and test for edge cases).

There's supposed to be a south migration for existing users, right?

— Reply to this email directly or view it on GitHub https://github.com/Claremont-HvZ-Web-Team/claremontHvZ/pull/195#issuecomment-53648378 .

[jthemphill]

2) I mostly want someone to talk to him so he doesn't feel left out of the loop. 3) Cool. brains is a good idea then. Do you need to add it to the admin page too, so mods can tweak it easily? 6) Nope, we have persistent users already. 8) Cool, that sounds painless.

You can make the changes whenever. I'll test when I think the stable-requirements.txt and persistent users issues are fixed

[ranneyd]

2) Telling JT to do it 3) Nah it's automatic since you can go to player pages 6) Will fix it in the next push then 8) Hopefully yes

When I have it all ready I'll submit another pull request

On Wed, Aug 27, 2014 at 3:26 PM, Jeff Hemphill notifications@github.com wrote:

2) I mostly want someone to talk to him so he doesn't feel left out of the loop. 3) Cool. brains is a good idea then. Do you need to add it to the admin page too, so mods can tweak it easily? 6) Nope, we have persistent users already. 8) Cool, that sounds painless.

You can make the changes whenever. I'll test when I think the stable-requirements.txt and persistent users issues are fixed

— Reply to this email directly or view it on GitHub https://github.com/Claremont-HvZ-Web-Team/claremontHvZ/pull/195#issuecomment-53649854 .

[jthemphill]

You can just push new commits onto this branch, and it will update the pull request.

[jthemphill]

Before submitting the next batch of code, you should clone a fresh copy of your code in a new virtualenv and run the build script to make sure the site will build for others as cleanly as it did for you.

[ranneyd]

Should I do it before or after I update stable-requirements? Or both?

On Wed, Aug 27, 2014 at 10:35 PM, Jeff Hemphill notifications@github.com wrote:

Before submitting the next batch of code, you should clone a fresh copy of your code in a new virtualenv and run the build script to make sure the site will build for others as cleanly as it did for you.

— Reply to this email directly or view it on GitHub https://github.com/Claremont-HvZ-Web-Team/claremontHvZ/pull/195#issuecomment-53675546 .

[jthemphill]

Oh! After. The one-step build process installs all the packages in the requirements.txt files, so the site won't build cleanly if you haven't listed all of the packages in there.

Sorry, I forgot to say this earlier. stable-requirements.txt represents packages that go to the server and dev-requirements.txt represents packages that new developers have to install. South and longerusername are packages that should go in both requirements files.

[ranneyd]

Yeah I got that. I figured I'd wait until I updated that but I wanted to ask to make sure.

Thanks!

On Thu, Aug 28, 2014 at 10:58 AM, Jeff Hemphill notifications@github.com wrote:

Oh! After. The one-step build process installs all the packages in the requirements.txt files, so the site won't build cleanly if you haven't listed all of the packages in there.

Sorry, I forgot to say this earlier. stable-requirements.txt represents packages that go to the server and dev-requirements.txt represents packages that new developers have to install. South and longerusername are packages that should go in both requirements files.

— Reply to this email directly or view it on GitHub https://github.com/Claremont-HvZ-Web-Team/claremontHvZ/pull/195#issuecomment-53766956 .

[ranneyd]

So we need south and my app in the installed_apps list otherwise the apps aren't actually included in the django project (though the stable-requirements.txt file does install). So I'm reverting that change

On Thu, Aug 28, 2014 at 1:54 PM, Dustin Kane dustinpkane@gmail.com wrote:

Yeah I got that. I figured I'd wait until I updated that but I wanted to ask to make sure.

Thanks!

On Thu, Aug 28, 2014 at 10:58 AM, Jeff Hemphill notifications@github.com wrote:

Oh! After. The one-step build process installs all the packages in the requirements.txt files, so the site won't build cleanly if you haven't listed all of the packages in there.

Sorry, I forgot to say this earlier. stable-requirements.txt represents packages that go to the server and dev-requirements.txt represents packages that new developers have to install. South and longerusername are packages that should go in both requirements files.

— Reply to this email directly or view it on GitHub https://github.com/Claremont-HvZ-Web-Team/claremontHvZ/pull/195#issuecomment-53766956 .

[jthemphill]

Hmm... the build didn't actually pass --- you can see the error message in the link. I need to fix the error codes for the build script.

[ranneyd]

Did you fix it already? Because it says it passed.

Also at what point do we push to the site and run the commands:

python manage.py syncdb python manage.py migrate longerusernameandemail

On Fri, Aug 29, 2014 at 10:07 AM, Jeff Hemphill notifications@github.com wrote:

Hmm... the build https://travis-ci.org/Claremont-HvZ-Web-Team/claremontHvZ/builds/33869959 didn't actually pass --- you can see the error message in the link. I need to fix the error codes for the build script.

— Reply to this email directly or view it on GitHub https://github.com/Claremont-HvZ-Web-Team/claremontHvZ/pull/195#issuecomment-53903539 .

[jthemphill]

Mm, during the game simulation step, the build says

django.db.utils.IntegrityError: column email is not unique

The error was that the buildbot reports successes even when things crash horribly.

And yeah, you'll run those commands via SSH.

[jthemphill]

Okay, I think longerusernameandemail is causing username conflicts during registration. It's really weird. According to its github page, it looks like they recommend just making a custom user model if you have Django 1.5. We're on Django 1.6, so I wouldn't be terribly surprised if the plugin were no longer compatible.

If you take out the longerusernameandemail stuff so that the build works (and uncomment the long email unit test), I'll accept that for the pull request. If you would like, I'd be happy to send you a pull request creating the custom user model if you're getting tired of build errors.