Clarifai / clarifai-python-grpc

Clarifai gRPC Python API client

https://docs.clarifai.com

Other

56 stars 20 forks source link

Add models for python grpc testing #98

Closed ackizilkale closed 2 years ago

ackizilkale commented 2 years ago

Eagle 2050

Add new model tests
Increase test timeout to 30 mins

Developed by @steph-en-m . I opened the PR since the tests were running into authorization issues in his PR.

ackizilkale commented 2 years ago

I agree. @steph-en-m is this the list you agreed with @cemigo114 ? For instance, FACEBOOK_TRANSLATION_MODELS is very long.

stmugisha commented 2 years ago

We aren't testing all translation models. I will remove some more models though to shorten the tests.

stmugisha commented 2 years ago

Removed some of the models from tests. #99 ( kept tests for the most commonly used translation models)

ackizilkale commented 2 years ago

Oh there is also this. These are big models. So I will increase this group slowly also.

ackizilkale commented 2 years ago

yeah that makes sense. Just pushed the code.

HarmitMinhas96 commented 2 years ago

If you did the above mentioned refactor, then a lot of the vars in tests/common.py can also be moved since they're only there for the public models test