search

Clarity-89 / grafana-finnhub

Finnhub plugin for Grafana
Apache License 2.0
6 stars 4 forks source link

Broken datasource #20

Closed sluongng closed 2 years ago

sluongng commented 2 years ago

There are 2 issues when I tried to use this for my home setup:

  1. The test query for datasource is using /profile url, which require a paid subscription. Instead, I suggest using https://finnhub.io/docs/api/company-profile2 which is free

  2. When trying to explore data or setup new dashboard, the datasource error out like this image

TypeError: Cannot read properties of null (reading 'split')

    at input
    at div
    at div
    at http://grafana.pi2.home/public/build/7095.1322a38d8e955d3d27e7.js:641:1000
    at div
    at div
    at p (http://grafana.pi2.home/public/build/7095.1322a38d8e955d3d27e7.js:396:27)
    at form
    at dd (http://grafana.pi2.home/public/build/7095.1322a38d8e955d3d27e7.js:3095:3961)
    at k (http://grafana.pi2.home/public/plugins/clarity89-finnhub-datasource/module.js:2:11453)
    at Sl (http://grafana.pi2.home/public/build/7095.1322a38d8e955d3d27e7.js:2870:458)
    at Tl (http://grafana.pi2.home/public/build/7095.1322a38d8e955d3d27e7.js:2870:1006)
...

Which suggests that there is some incompatibility with my grafana version: Grafana v8.3.4 (a551d74b11) (fairly recent)

Clarity-89 commented 2 years ago

Hi @sluongng, thank you for the issue. I haven't updated this datasource to be compatible with Grafana 8 yet, will try to find the time to do it soon.

Clarity-89 commented 2 years ago

Should be fixed by https://github.com/Clarity-89/grafana-finnhub/pull/21