ClarkuCSCI / pydiode

Transfer data through a unidirectional network (i.e., a data diode)
MIT License
2 stars 0 forks source link

KeyboardInterrupt Exception when Cancelling Receiving #19

Closed peterstory closed 4 hours ago

peterstory commented 5 days ago

A stack trace containing a KeyboardInterrupt exception is displayed when cancelling receiving.

Not observed on macOS, testing with either the main or user-study branches. The error does occur when running from the .app!

Observed on Linux when using the .deb installer. Not observed when installed from either the main or user-study branches. So this issue is specific to PyInstaller: https://github.com/pyinstaller/pyinstaller/issues/3646

This code suggests that pyinstaller always exits with -1 or a successful return code: https://github.com/pyinstaller/pyinstaller/pull/3515/files#diff-6f619220d264acecf4826ad08ebc2ef4881ecd22b92f4561a7b1ae2be399b8c4R886

peterstory commented 5 days ago

Tests:

Completed:

Finally:

peterstory commented 5 days ago

Known error states:

In both cases, we have non-zero exit codes. But we only want to show an error in the second case.

peterstory commented 4 hours ago

I tested with the rebased code on Linux, and I'm not getting an error when I click "Cancel Receiving." Everything seems to work properly!