search

ClassiCube / ClassiCube

Custom Minecraft Classic / ClassiCube client written in C from scratch (formerly ClassicalSharp in C#)
Other
1.46k stars 217 forks source link

Weird lava hitbox #900

Open ghost opened 3 years ago

ghost commented 3 years ago

The lava hitbox has wrong position. Normally not noticeable, but when you want to jump next to the corner of lava (surrounded by other blocks), you will swim instead.

Example on video: https://www.youtube.com/watch?v=-vQ6I_wHEFo Notice that the hitbox corner is seen outside of the glass border. It's only on this single side.

Goodlyay commented 3 years ago

The original Minecraft classic 0.30 client behaved this way, and the matching behavior in ClassiCube client is intentional.

ghost commented 3 years ago

Ok. But could some option exist to turn that off, since it's sometimes annoying when you don't expect it? Not saying that it has to be added.

Goodlyay commented 3 years ago

Using BlockDefinitions you can make your own faux water block that uses collide "1" (Swim-through), which does not implement the offset hitbox.

On MCGalaxy, this should be as simple as: /lb copy 9, then /lb edit [ID that 9 was copied to] collide 1

sadkris commented 3 years ago

Should be closed. Solution discussed, no implementation needed.

Goodlyay commented 3 years ago

Should be closed. Solution discussed, no implementation needed.

I would leave that up to UnknownShadow200.

One thing I didn't mention is that you technically cannot create a perfect copy of water or lava without the offset hitbox, because "swim-through" collide has slightly different physics behavior than normal water. Therefore, RealKalsep's suggestion of being able to "turn off" the offset is not completely possible.

ghost commented 3 years ago

Thank you for the explanation. I will try to avoid making similar mistakes from now on. Didn't find this on the issue closed and open list before, and never played the original classic as much as ClassiCube, so that's why I created this issue page.