ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software
GNU General Public License v3.0
172 stars 80 forks source link

Prevent players using /reload inside of games. #612

Closed forkiesassds closed 3 years ago

forkiesassds commented 3 years ago

This is done to prevent people noclipping through the map by spamming /reload. The first commit vscode files and 64-bit support is so I could work on MCGalaxy though Visual Studio Code.

Goodlyay commented 3 years ago

Because the issue is that you can clip through walls with /reload, the solution should be to disable it when noclip itself is disabled (-hax, -noclip). Targeting the issue to games is overly specific and possibly inaccurate.

"The first commit vscode files and 64-bit support is so I could work on MCGalaxy though Visual Studio Code." I recommend you include this in a separate pull request if you intentionally want to add this to MCGalaxy. Otherwise, it should be excluded from the commits

forkiesassds commented 3 years ago

Because the issue is that you can clip through walls with /reload, the solution should be to disable it when noclip itself is disabled (-hax, -noclip). Targeting the issue to games is overly specific and possibly inaccurate.

"The first commit vscode files and 64-bit support is so I could work on MCGalaxy though Visual Studio Code." I recommend you include this in a separate pull request if you intentionally want to add this to MCGalaxy. Otherwise, it should be excluded from the commits

I've disabled /reload when noclip is disabled and excluded the first commit from the pull request.

UnknownShadow200 commented 3 years ago

Thanks