ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software
GNU General Public License v3.0
172 stars 80 forks source link

Allow /perbuild/visit to accept multiple tokens. #613

Closed forkiesassds closed 3 years ago

forkiesassds commented 3 years ago

Might need some improvements.

Closes #368.

Goodlyay commented 3 years ago

I don't really understand the purpose of this, but if I'm understanding correctly, then it allows multiple people to have their permissions changed at the same time? You should update the help of the commands to reflect this expansion of syntax. But it seems unnecessary to me

EDIT: I only just noticed this is addressing an existing issue, so I guess that answers my question of what the purpose is

UnknownShadow200 commented 3 years ago

Unfortunately several issues here

Not an issue with this pull request specifically, but I'm a little bit reluctant towards providing a way for someone to easily clear an entire whitelist with just -*

I apologise if this comes off as overly critical