Misleading log message in Server Init, should be placed in ClassiCube Heartbeat implementation

ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software

GNU General Public License v3.0

172 stars 80 forks source link

Misleading log message in Server Init, should be placed in ClassiCube Heartbeat implementation #626

Closed johannespartin closed 3 years ago

johannespartin commented 3 years ago

In the Server Init method static void InitRest(Scheduler Task) the following message is logged: "Finished setting up server, finding classicube.net url.."

This should be implemented once the uuid is requested within the heartbeat implementation.

https://github.com/UnknownShadow200/MCGalaxy/blob/16cc7085013bc7f5ad38ea9871293b7c4b98c348/MCGalaxy/Server/Server.Init.cs#L137

UnknownShadow200 commented 3 years ago

Does 2e1c4e9b61a06716060a7af8fa3de4ed1a68015f resolve this?

johannespartin commented 3 years ago

Looks good to me. Thank you!