search

ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software
GNU General Public License v3.0
172 stars 80 forks source link

Multiple user defineable heartbeat adresses. #636

Closed forkiesassds closed 2 years ago

forkiesassds commented 2 years ago

Might also include prefix or suffix support to allow separation from which server list players joined.

MisterSheeple commented 2 years ago

I support this.

UnknownShadow200 commented 2 years ago

Depends how different the heartbeats need to be: Just sending the same heartbeat (with differing salt) to multiple providers isn't too tricky. But if a heartbeat provider requires different fields to be sent, that's much more difficult

MisterSheeple commented 2 years ago

Depends how different the heartbeats need to be: Just sending the same heartbeat (with differing salt) to multiple providers isn't too tricky. But if a heartbeat provider requires different fields to be sent, that's much more difficult

If I'm not mistaken, Betacraft's heartbeat is more or less similar to ClassiCube's, so if adding support for more heartbeats needs to be done on a per-provider basis, I don't think adapting Betacraft would be that difficult of a thing to do.

forkiesassds commented 2 years ago

Possibly allow users to like arrange the heartbeat URL as a string or something like that.

MisterSheeple commented 2 years ago

actually hold on, I know for fact this should be an easy job and here's why:

I've outright replaced the classicube heartbeat with betacraft in the past and everything worked fine. i doubt many (if any) changes would have to be made. Please consider adding support for this.

craftycodie commented 2 years ago

Picking up this task.

UnknownShadow200 commented 2 years ago

fyi I am currently working on this

craftycodie commented 2 years ago

fyi I am currently working on this

Spotted that a little too late lol. PR'd anyway, curious to see how our implementations differ.

forkiesassds commented 2 years ago

The reason why I suggested an option to include a prefix or suffix for players that join from certain server lists is so if a server list uses a different auth system from other server lists it would help preventing impersonation of players that come from server list x by registering someone's username on server list y and joining the server they want to impersonate on.