#636 Added support for multiple heartbeats.

ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software

GNU General Public License v3.0

172 stars 80 forks source link

#636 Added support for multiple heartbeats. #640

Closed craftycodie closed 2 years ago

craftycodie commented 2 years ago

Per #636 I have added support for registering multiple heartbeat urls.

At the moment all are using the ClassiCube heartbeat. This could be extended to support various heartbeat protocols and implementations (eg, classicube://someurl.com, betacraft://betacraft.pl/heartbeat.jsp etc). Though personally I think that one implementation passing as much relevant data as suitable should be enough, and that we shouldn't have different consumer API specs (so the classicube spec should be fit for betacraft and if not, betacraft should adapt).

Split out the heartbeat service and heartbeat datatype into separate classes.
Changed the HeartbeatURL config option to HeartbeatURLs.

craftycodie commented 2 years ago

Apologies for the nasty diffs. I've tried CRLF and LF, it doesn't seem to like either for whatever reason. You can view the changes with this:

UnknownShadow200 commented 2 years ago

Appreciate the pull request, but came across several issues when testing

Always get an ArgumentNullException: Value cannot be null. error on startup when saving server.properties
Always have to wait 30 seconds now for server URL to appear
Custom heartbeat URL config option from current MCGalaxy stopped working (due to the server config option being renamed from HeartbeatURL to HeartbeatURLs)
/server reload doesn't update heartbeat URL anymore