search

ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software
GNU General Public License v3.0
168 stars 79 forks source link

/Museum and /restore should use historic blockdefs #653

Open rdebath opened 2 years ago

rdebath commented 2 years ago

Museum will load the block definitions of the current version of the level. For correct rendition it should use the blocks defined in the saved files.

Mitigation: Blockdefs are usually only added to so the current version is normally sufficient.

UnknownShadow200 commented 2 years ago

Probably should also load the other backed up files too (e.g. level properties), as that was one of original motivations behind adding backups of the metadata files too

rdebath commented 1 year ago

Like /museum the command /restore doesn't seem to know about files other than the basic block array.

PS: Looks like /RestoreSelection can replicate what /restore currently does by using /ma.

Goodlyay commented 1 year ago

I know this is an XKCD "workflow" moment, but if /restore is implemented to restore blockdefs, bots, etc, then there needs to be an option to restore only blocks like it used to.

rdebath commented 1 year ago

:grin: I noticed and added a "PS".

The /RestoreSelection is basically identical if you choose the blocks using /ma. The differences being that it honours the draw limit and actually saves the restoration into the blockdb so you get a nice history.

I suppose a /RestoreBlocks alias for this might be nice.

Goodlyay commented 1 year ago

I didn't catch that. Seems like it would work