ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software
GNU General Public License v3.0
162 stars 76 forks source link

Overseer level names collide -- User can add too many maps #702

Open rdebath opened 2 years ago

rdebath commented 2 years ago

With the removal of the + from the end it's easy for an account to be created that blocks someone else creating their additional maps. ie:

Old style:

UnknownShadow200 commented 2 years ago

/os map add should be automatically skipping over maps that don't belong to the user

image

rdebath commented 2 years ago

Okaaay, yes, that's not confusing at all. Create seems to skip other owned maps correctly; /os go <N> doesn't though.

I still think adding a string between the user and the number is a good idea, defined in the properties of course. At this point it might be a good idea to add all three of a prefix, suffix and the infix strings. That way it can be made easy to distinguish the OS levels from the generic ones.

PS: Sorry, I should have tested what it would do, it wouldn't have stopped me raising an issue tho.

Goodlyay commented 2 years ago

How then does it count how many OS maps a player has made? Does it also skip in that case?

rdebath commented 2 years ago

Oh, dear, you're right @Goodlyay it counts them wrong, this sequence works ...

Builder has 4 maps when they're supposed to have 3.