ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software
GNU General Public License v3.0
162 stars 76 forks source link

Block permissions should be overridden for /about #714

Open rdebath opened 1 year ago

rdebath commented 1 year ago

The about command doesn't change any block so if the server is asking for a block to mark for this it should allow the client to mark any block, even on levels where place and delete are not allowed.

This also applies to /measure and may apply if /mode is in effect so that any block the user might place will be replaced.

Might also allow place/delete if these are disabled, but draw commands are enabled.

UnknownShadow200 commented 1 year ago

So essentially you want PlayerClick to also activate these selection commands?

rdebath commented 1 year ago

That's a possible solution, another possibility is to turn off the client side block permissions just while the command is active and revert the client side block change.

No idea which is better, I suspect it depends partly on if there's any client that has block permissions but not playerclick, if there's something expensive about toggling the permissions (client side). Oh, and does PlayerClick allow you to click the empty space (air block), like placing a block does.

Does there even exist a (real GUI) client that has CPE and isn't Classicube?

Goodlyay commented 1 year ago

Oh, and does PlayerClick allow you to click the empty space (air block), like placing a block does.

PlayerClick gives you the block face that was clicked, so you can extrapolate the placed block position from checking if right click and offsetting coords based on face clicked