ClassiCube / MCGalaxy

A Minecraft Classic / ClassiCube server software
GNU General Public License v3.0
162 stars 76 forks source link

/whonick doesn't deal with duplicate nicks. #730

Open rdebath opened 1 year ago

rdebath commented 1 year ago

/whonick only shows the first player with a particular nick and complains about multiple players if you use a substring.

> /who
There are 3 players online.
:SuperOPs: red-green-blue (main)
:Anarchists: guesty (main)
:Guests: guesty (main)
> /whonick guest
2 online player nicks match "guest":
guesty, guesty
> /whonick guesty
The player nicknamed guesty is named test+
>
UnknownShadow200 commented 1 year ago

If matching players have different nicknames, should they all be shown still?

e.g. /whonick guest with guestx, guesty, guestz

rdebath commented 1 year ago

I expect the simplest would be just to show all the online users that have matching nicks even if there's multiple users.

If it can do offline then some sort of limitation of the number of hits is probably a good idea, but IMO something like "There are over 10 matches please be more specific" should be fine.