ClassicDIY / PylonToMQTT

Reads data from the Sage BMS console port and publishes to MQTT
22 stars 6 forks source link

5 second timeout on serial port #7

Open ellingo opened 1 year ago

ellingo commented 1 year ago

Every command to a battery takes 5 seconds because you use readline(). Every response from a battery ends with CR, not LF. Wouldn't it be better to use read_until(b'\r') instead?

That said, I have learned a lot from your project because of its completeness. Thank you!