search

ClassicOS-Themes / ClassicOS-2000-Theme

GNU General Public License v2.0
1 stars 0 forks source link

No background upon selecting text #1

Open GreenLunar opened 1 year ago

GreenLunar commented 1 year ago

Selected text gets darker, but no background is rendered.

ClassicOS-Themes commented 1 year ago

In which program is this behavior appearing in? Text selection seems to be working fine with a standard Gtk3 GtkEntry, so it seems I'd need a bit more information to identify and reproduce the issue.

GreenLunar commented 1 year ago

On Mon, 21 Nov 2022 13:50:06 -0800 ClassicOS-Themes @.***> wrote:

In which program is this behavior appearing in? Text selection seems to be working fine with a standard Gtk3 GtkEntry, so it seems I'd need a bit more information to identify and reproduce the issue.

Thunar 4.16.11 GTK+ 3.24.34 (1:3.24.34+r156+g812b3930d0-1) ArchLinux

ClassicOS-Themes commented 1 year ago

That's weird - I am also on gtk3 1:3.24.34+r156+g812b3930d0-1 on Arch and I do not experience this issue in thunar 4.16.11. I do have libxfce4ui-nocsd (aur package) installed - maybe that has something to do with it?

That said, I did some looking around in different programs and I think I spotted a similar issue to what you're describing in MySql Workbench - Text Entry doesn't show selection background, but text is not getting darker.

I'll try to address the issue I'm seeing in Workbench over the weekend, and hopefully it fixes the issue you're seeing.

ClassicOS-Themes commented 1 year ago

So, looks like the issue I was seeing in workbench is present with literally every GTK3 theme I've tried.

I made a couple changes to hopefully resolve the issue you're experiencing here, but as I've never been able to reproduce the issue, I can't tell if it worked or not. Please let me know

GreenLunar commented 1 year ago

Looks good.

Tested with About dialog and Chat displays of Dino and Gajim.

Is it possible to handle the contrast of hyperlinks?

GreenLunar commented 1 year ago

From Gajim (same for Dino) classicos-2000_gajim

ClassicOS-Themes commented 1 year ago

I'll see what I can do for that - might have time today, might not. I'm hoping it'll be pretty straightforward once I get down to it

ClassicOS-Themes commented 1 year ago

Well, so much for it being straightforward: It doesn't seem like there's a way to do this. None of the other themes on my system (Adwaita, Chicago95, Greybird, etc) seem to deal with selected links.

I tried a whole bunch of different CSS selectors to try to affect selected links, all to no avail.

Looking in the GTK inspector's CSS nodes view, it seems like "link" and "selection" are each their own nodes, and are siblings, so I'm not sure it'll ever be possible without upstream fixes.