ClassicOldSong / moonlight-android

GameStream client for Android
GNU General Public License v3.0
261 stars 7 forks source link

[Issue]: Direct touch triggers click event on old mouse position #18

Closed Sa1ev closed 4 weeks ago

Sa1ev commented 1 month ago

Describe the bug

https://www.reddit.com/r/MoonlightStreaming/comments/1ciqbt8/bugandroid_direct_touch_triggers_click_event_on/ I has similar issue when you select Mluti touch (guess typo in resources), but i have no idea if you can reproduce it. I checked logs, there is correct event sending sequence on each click (sendMousePosition==2 -> sendMousePosition==4 -> sendMousePosition==5), but my guess is that on receiveng side in handles click event before mouse position change event. For my build I simply put a 50ms delay before sending MoonBridge.sendMouseButton(MouseButtonPacket.RELEASE_EVENT, mouseButton) and MoonBridge.sendMouseButton(MouseButtonPacket.PRESS_EVENT, mouseButton) to let GeForce handle postion change and it solves the issue, but maybe you could find a better solution.

Steps to reproduce

select Mluti touch and just try to click or drag anything on screen

Affected games

No response

Other Moonlight clients

None

Moonlight adjusted settings

None

Moonlight adjusted settings (please complete the following information)

No response

Moonlight default settings

Yes

Gamepad-related connection issue

No

Gamepad-related input issue

No

Gamepad-related streaming issue

No

Android version

14

Device model

Galaxy Tab S9 Ultra

Server PC OS version

Windows 11, version 23H2

Server PC GeForce Experience version

No response

Server PC Nvidia GPU driver version

No response

Server PC antivirus and firewall software

No response

Screenshots

No response

Relevant log output

No response

Additional context

No response

ClassicOldSong commented 4 weeks ago

Cannot reproduce on my devices, might this be a Samsung specific issue since DeX might introduce some variances.

Can you try Apollo and see if this issue presists?

Sa1ev commented 4 weeks ago

Well, I can't reproduce it with Apollo + non-modified Artemis; it's probably a problem on GeForce side then.

ClassicOldSong commented 4 weeks ago

GFE is no longer recommended as Nvidia has abandoned the project. Input batching/dropping is a known issue there.