search

ClassicPress / ClassicPress-Migration-Plugin

Switch your WordPress installation to ClassicPress.
Other
26 stars 20 forks source link

add text to the switching screen #11

Closed senlin closed 6 years ago

senlin commented 6 years ago

Add text to the switching screen to inform the user of what is going to happen and that it can take a while.

Also add the ClassicPress slogan

nylen commented 6 years ago

We need to make all of these strings available for translation, otherwise this is a good starting point. Can you update the PR with the appropriate calls please? Something like this:

<p>
    <?php _e( 'text string here', 'switch-to-classicpress' ); ?>
</p>
senlin commented 6 years ago

Of course, sorry for that, wasn't thinking about that.

senlin commented 6 years ago

@nylen By the way, there might be an issue with the textdomain/slug. According to the WP Plugin Guidelines the textdomain and the slug need to be the same. In this case, the textdomain is switch-to-classicpress, but earlier today I asked @scottybo what the slug is and that is much longer: switch-to-classicpress-from-wordpress

nylen commented 6 years ago

As discussed on Slack, we're going to see if we can change the plugin slug.

PR looks good, thanks for the improvements.