search

ClassicPress / ClassicPress-Migration-Plugin

Switch your WordPress installation to ClassicPress.
Other
26 stars 20 forks source link

Install latest ClassicPress version #68

Closed nylen closed 3 years ago

nylen commented 4 years ago

Right now the migration plugin installs ClassicPress version 1.1.1, and we are on 1.1.2 as of this writing.

In order to fix this we need to restore the nightly builds first.

Split off from #66:

Apart from the need to bump to 1.1.2. On bumping to 1.1.2. All is well

Screenshot 2019-12-18 at 18 04 37

ClassyBot commented 4 years ago

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/blank-screen-when-using-the-migration-plugin/2158/12

mattyrob commented 3 years ago

As far as I can tell the change here needs to be applied in the API: https://api-v1.classicpress.net/migration/

And I wonder why we are using nightly builds that may inherently but less stable as compared to the official release location

@striebwj - can you update the API returned data?

It think we should use: https://github.com/ClassicPress/ClassicPress-release/archive/refs/tags/1.2.0.zip (for the moment)

striebwj commented 3 years ago

Looks like we need to update here: https://github.com/ClassicPress/ClassicPress-APIs/blob/master/v1/migration/index.php

ClassyBot commented 3 years ago

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/classicpress-migrator-updates-to-1-1-1-nightly-build-instead-of-1-2-0/3388/3

ClassyBot commented 3 years ago

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/migration-plugin-work-required/3393/1

nylen commented 3 years ago

It think we should use: https://github.com/ClassicPress/ClassicPress-release/archive/refs/tags/1.2.0.zip

This won't work. The reason is that WordPress requires update packages to contain a folder named wordpress, but the ClassicPress official release packages contain a folder named like ClassicPress-release-1.2.0.

This is what the "migration" nightly builds are for, but this step needs to be automated so that we don't have to do each release twice. Now that the nightly builds are back up and running, this issue is only waiting on the stable release of version 1.3.0.

And I wonder why we are using nightly builds that may inherently but less stable as compared to the official release location

This isn't an issue. Once the official 1.3.0 release is out, you wait until (a few minutes after) midnight UTC comes around again, then update the migration API endpoint mentioned above to use the very next "migration" build that appears at https://github.com/ClassyBot/ClassicPress-nightly/releases. This is guaranteed to be the same as the official 1.3.0 release.