ClassicPress / ClassicPress-Migration-Plugin

Switch your WordPress installation to ClassicPress.
Other
26 stars 20 forks source link

Add Plugin and Theme check sections #74

Closed mattyrob closed 3 years ago

mattyrob commented 3 years ago

This PR adds compatibility sections that check for known incompatible plugins active on an install and also for incompatible theme in use (Twenty Twenty-One)

This change is contingent on an update to the migrate API, for which there is already a PR.

https://github.com/ClassicPress/ClassicPress-APIs/pull/24

nylen commented 3 years ago

I left some specific comments above. More generally, I'm a bit concerned that these checks will offer a false sense of security: since we can't catch all incompatibilities, we probably shouldn't show a green checkmark when the plugin doesn't find anything that's not a known incompatibility. I'm not sure the best way to handle this in the UI though - maybe only show this check if it fails?

mattyrob commented 3 years ago

I have updated the PR as follows:

ClassyBot commented 3 years ago

This pull request has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/migration-plugin-work-required/3393/1

ClassyBot commented 3 years ago

This pull request has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/migration-plugin-work-required/3393/2

striebwj commented 3 years ago

@mattyrob I think this is good to go now that we got the api update in?

mattyrob commented 3 years ago

@striebwj The API being there means the plugin and theme checks are now operational, provided everyone is happy with the way the information is presented to users when migrating it can be pushed and released. I think all of the comments by @nylen have been addressed. So, would just need another approval and we can push on.

striebwj commented 3 years ago

Let's push on, merging this and tagging a new release 👍