search

ClassicPress / ClassicPress-Migration-Plugin

Switch your WordPress installation to ClassicPress.
Other
25 stars 19 forks source link

Add theme header comparison check to compatibility logic #76

Closed mattyrob closed 3 years ago

mattyrob commented 3 years ago

This PR adds a compatibility check to Theme Headers to check the value is not 5.0 or above.

It may need more work to assess what happens if that header is not present.

mattyrob commented 3 years ago

I've done a bit more playing around and extended the logic in the Theme checking.

1/ Display a blocking message if we know there is an issue via the API 2/ Display a warning message if the 'RequiresWPheader is not present (interestingly is is not consistently use in past core themes so we may need to recommend a specific theme - or perhaps better yet, our own theme) 3/ Display a blocking message if the 'RequiresWP header indicates a higher version (5.0 or above) is needed. 4/ If all the above are not displayed show a message saying we are not aware of any issues.

Updated patch to follow, happy for feedback and further adjustments can be made yet.

mattyrob commented 3 years ago

I've amended that string as proposed.