search

ClassicPress / ClassicPress-v1

A copy of ClassicPress v1.x.
1 stars 1 forks source link

Update Dashicons icon font #82

Closed ControlledChaos closed 3 years ago

ControlledChaos commented 3 years ago

Expected behavior

Any icon in the Dashicons reference should be displayed when added in HTML or in CSS.

Current behavior

Several icons added to the Dashicons icon font since the ClassicPress fork do not display when added in HTML or in CSS.

Possible solution

Replace icon font files in the ClassicPress repository with thos from the Dashicons repository.

Steps to reproduce

  1. Go to the Dashicons reference for the database icon.
  2. Copy the HTML for displaying this database icon.
  3. Paste the HTML into the template of a ClassicPress administration screen.
  4. View the screen where the icon markup was pasted.

Context

I have developed plugin administration interfaces with Dashicon icons in the HTML markup and in CSS stylesheets. Several of these icons do not display when testing in ClassicPress whereas they do display in WordPress.

nylen commented 3 years ago

Thanks for creating an issue. The best way to address this would be to find all the WP changesets (commits) that involve updating the dashicons and backport them using these steps: https://github.com/ClassicPress/ClassicPress/blob/develop/.github/CONTRIBUTING.md#backporting-changes-from-wordpress

mattyrob commented 3 years ago

I've don't a little searching back and I think there are 6 change sets needed to get dahicons up to date:

https://core.trac.wordpress.org/changeset/44940 https://core.trac.wordpress.org/changeset/45040 https://core.trac.wordpress.org/changeset/45225 https://core.trac.wordpress.org/changeset/48456 https://core.trac.wordpress.org/changeset/48506 https://core.trac.wordpress.org/changeset/49263

If anyone feels inclined to check this over and if agreed I'll create a PR for these and anymore we fine.