search

ClassicPress / ClassicPress-v2

NOT READY FOR PRODUCTION.
GNU General Public License v2.0
13 stars 4 forks source link

` wp doctor check core-verify-checksums` not working 🐞 #235

Open xxsimoxx opened 11 months ago

xxsimoxx commented 11 months ago

Expected behavior

Report results.

Current behavior

It freezes.

Possible solution

No response

Steps to reproduce bug

From command line wp doctor check core-verify-checksums.

Context

No response

ClassicPress version

1.7.0 2.0.0

PHP version

7.4

Can you help?

I'll check what's happening.

xxsimoxx commented 11 months ago

Can not find a way to fix this.

wp doctor check core-verify-checksums uses a call to wp core verify-checksums. wp core verify-checksums is obviously failing checks as WP files are different. Both commands don't load CP (nor WP), so we can't hook at before_invoke like in this PR.

Don't know why wp doctor check core-verify-checksums hangs instead of reporting checksum mismatch, but clearly those commands are not useful to ClassicPress users.

So my proposal is to close this issue.

viktorix commented 11 months ago

That's probably because it uses API to get checksums: https://github.com/wp-cli/checksum-command/blob/main/src/Checksum_Plugin_Command.php#L20

Would it be worth checking if they would accept a PR to add --classicpress option that would replace the API endpoint?