search

ClassicPress / ClassicPress-v2

NOT READY FOR PRODUCTION.
GNU General Public License v2.0
13 stars 4 forks source link

WP-r55888: Script Loader: Improve performance of wp_maybe_inline_styles function. #272

Closed mattyrob closed 10 months ago

mattyrob commented 10 months ago

Description

Script Loader: Improve performance of wp_maybe_inline_styles function.

The wp_maybe_inline_styles function is called twice on the average page load. On it's second run however, it did not check to see if the style had already been processed on the first run. This resulted in calling filesize and get_file_contents unnecessarily, which was bad for performance. Now, the loop around the queued styles, checks to see if the source is set to false, meaning it has already been processed. This change also replaces calls to filesize with the core function wp_filesize, which improves extensibility.

Props spacedmonkey, flixos90, peterwilsoncc, joemcgill.

https://core.trac.wordpress.org/changeset/55888

Motivation and context

Backport of upstream efficiency enhancement

How has this been tested?

This is a backport, local tests have been passing.

Screenshots

N/A

Types of changes

mattyrob commented 10 months ago

Has two approvals, merging in preparation for v2 repository migration.