ClassicPress / classic-commerce

A simple but powerful e-commerce platform built for ClassicPress. Forked from WooCommerce and compatible with many Woo extensions.
https://classiccommerce.cc/
GNU General Public License v3.0
54 stars 15 forks source link

Fix errors in build process. #21

Closed bahiirwa closed 5 years ago

bahiirwa commented 5 years ago

Describe the bug Travis CI fails with bash scripts test in PHP 5.2, 5.3 and 7.2.

Pinging @nylen

nylen commented 5 years ago

For PHP 5.2 and 5.3 the easiest thing to do is just to delete these jobs from .travis.yml, ClassicPress only supports PHP >= 5.6 so we don't need to worry about that.

The phpunit errors should be fixable by incorporating some of the latest commits from WooCommerce travis.yml into this repository. (It might be a good idea to consider a script to help with this, like the one we have for ClassicPress, and there is also a web app to display which commits we have already backported.)

The "Invalid package name" warning should be fixed by editing composer.json as follows:

- "name": "ClassicPress-research/classic-commerce",
+ "name": "classicpress-research/classic-commerce",

Unfortunately it does look like there is more fixing needed after that... the best way to address it will be to get the various parts of the Travis build running on your local machine.

bahiirwa commented 5 years ago

Could you do a PR? Advanced Bash is not my cup of tea.

nylen commented 5 years ago

Sorry I missed the above comment. Digging into this will probably take a few hours which I don't have right now, but let me know if you have specific questions.

Travis CI runs a bunch of things in order to test the build, they are defined in the .travis.yml file. You can't run a .travis.yml file directly on your computer, so the idea is to get the same pieces running instead. I'd start with phpunit, here are some instructions: https://github.com/ClassicPress-research/classic-commerce/tree/master/tests

bahiirwa commented 5 years ago

I have realized there is a step I was skipping in the contributions. I am going to add this to the README.md. This reduces some of those issues that Travis shouts out.

bahiirwa commented 5 years ago

Pinging @nylen

Some of the links to the build we should be checking have changed. Please check in the /tests/bin & /tests/cli to fix the nightly and CP build links for repo. There are lots of WP stuff there.

bahiirwa commented 5 years ago
+mysqladmin create woocommerce_test --user=root --password= --host=localhost --protocol=tcp

mysqladmin: [Warning] Using a password on the command line interface can be insecure.

mysqladmin: connect to server at 'localhost' failed

error: 'Can't connect to MySQL server on 'localhost' (111)'

Check that mysqld is running on localhost and that the port is 3306.

You can check this by doing 'telnet localhost 3306'