search

ClassicPress / classic-commerce

A simple but powerful e-commerce platform built for ClassicPress. Forked from WooCommerce and compatible with many Woo extensions.
https://classiccommerce.cc/
GNU General Public License v3.0
54 stars 15 forks source link

Change header text in uninstall.php? #283

Closed ghost closed 4 years ago

ghost commented 4 years ago

Is your feature request related to a problem? Please describe. uninstall.php in the root directory still has this text:

<?php
/**
 * WooCommerce Uninstall
 *
 * Uninstalling WooCommerce deletes user roles, pages, tables, and options.
 *
 * @package WooCommerce\Uninstaller
 * @version WC-2.3.0
 */

Describe the solution you'd like Should this be changed to CC? Or is there some reason it was left in?

timbocode commented 4 years ago

Yes, it should be changed to CC. No idea why this wasn't done in the first place. Probably just an oversight.

ghost commented 4 years ago

I think we were searching in all the sub-folders, but missed the top level.

bahiirwa commented 4 years ago

Initially we left this for a future plan to have a proper removal of all the data as the prompts suggests when uninstalling CC or WP.

Ref: https://github.com/ClassicPress-plugins/classic-commerce/issues/142

timbocode commented 4 years ago

Thanks Laurence. #142 is still open and currently scheduled for v1.1.0. I think we need to replace references to Woo but maybe we can also removed the ' * Uninstalling WooCommerce deletes user roles, pages, tables, and options.' line for now too as that's not what it currently does.

bahiirwa commented 4 years ago

Agree on replacing. However, could we add a

// TODO: Uninstalling WooCommerce deletes user roles, pages, tables, and options instead of deleting it.

Leaves context for what the file will do in the near future.

timbocode commented 4 years ago

Agreed. That's a better idea.