Fix new section in payments tab not working

ghost commented 2 years ago

All Submissions:

[x] Have you followed the Classic Commerce Contributing guideline?
[x] Does your code follow the repo standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Change the logic in the class-wc-settings-payment-gateways.php file so that new sections created under the Payments tab will work correctly. This was an existing bug in WC 3.5.3 that was later fixed with this PR: https://github.com/woocommerce/woocommerce/pull/22988

How to test the changes in this Pull Request:

Copy the revised class-wc-settings-payment-gateways.php file to a test installation
Create a new section following this tutorial: https://docs.woocommerce.com/document/adding-a-section-to-a-settings-tab/
- make sure you use the woocommerce_get_sections_checkout filter.
Visit the Payments tab in the setting and ensure that the new section is showing and the screen displays correctly when clicked.

Screenshot - before:

payments0

Screenshot - after:

payments2

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?
[x] Have you included screenshots before/after your changes, if applicable?

Discussion on forum is here: https://forums.classicpress.net/t/classiccommerce-not-triggering-filter-for-adding-settings-sections-in-tabs/3508

Thanks to arnandegans for bringing it to our attention.