Backport fix for missing product type dropdown in WP

ghost commented 2 years ago

All Submissions:

[x] Have you followed the Classic Commerce Contributing guideline?
[x] Does your code follow the repo standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

When Classic Commerce is used on WordPress 5.5+ the product type dropdown is missing. This is a known issue and was fixed in WooCommerce 4.3.2. There has been interest shown by some users in testing CC on WordPress before making a commitment to switch to ClassicPress. so it may be worth trying to backport this change into CC.

As far as I can tell, a function was added in class-wc-admin.php to check the WP version and apply an extra css class if necessary.

There is a condition added to meta-boxes-product.js to add this in, and some new css rules to handle the display.

NB. The current admin.css file is minimised so I have placed the new css at the end of the file. This is enough to get the dropdown to display, but it it still in the wrong place and this file needs more work.

Partially addresses #331 .

How to test the changes in this Pull Request:

On a test site running a recent WP version and CC, copy in the revised files:
- assets/css/admin.scss
- assets/js/admin/meta-boxes-product.js
- includes/admin/class-wc-admin.php
Create a new product and test the various options for product type using the dropdown.
Do the same on a site running CP and CC and make sure everything still works normally.

Screenshot - before:

before

Screenshot - after:

product-data-wp

Other information:

NB The new function in class-wc-admin.php only tests for WP version. I don't know what happens with CP and whether this test may cause problems later with higher CP versions. It might be worth adding a condition specifically to cater for CP sites (?).

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?
[x] Have you included screenshots before/after your changes, if applicable?