ClassicPress / classic-commerce

A simple but powerful e-commerce platform built for ClassicPress. Forked from WooCommerce and compatible with many Woo extensions.
https://classiccommerce.cc/
GNU General Public License v3.0
54 stars 15 forks source link

Sale ends at 00:00 instead of 11:59 PM on set day #342

Open ghost opened 3 years ago

ghost commented 3 years ago

Describe the bug The end date for a sale should be midnight on the date set for the sale to end. It currently end at 00:00 ie midnight of the day before. This issue was fixed in WC 3.5.4 https://github.com/woocommerce/woocommerce/issues/22186

To Reproduce Steps to reproduce the behavior:

  1. Set a product to be on sale ending today (starting today or earlier)
  2. Visit the product page
  3. The sale price should be shown
  4. Change the sale end date to previous day
  5. The sale price now shows

Expected behavior The sale should only end at the very end of the day (11:59 PM) and not when the day just starts.

Isolating the problem (mark completed items with an [x]):

ClassicPress Environment Classic Commerce version: 1.0.3 CMS version: You are running ClassicPress Version 1.3.0

ghost commented 3 years ago

.