search

ClassicPress / classic-commerce

A simple but powerful e-commerce platform built for ClassicPress. Forked from WooCommerce and compatible with many Woo extensions.
https://classiccommerce.cc/
GNU General Public License v3.0
50 stars 15 forks source link

Do we change WC version number in CC PR? #348

Closed ghost closed 2 years ago

ghost commented 2 years ago

Do we need to update the WC version numbers when we do a PR based on a later version of WC?

For example, in my recent PRs, there were lines like this in the original WC PR: 

 * @see https://docs.woocommerce.com/document/template-structure/
 * @package WooCommerce/Templates/Emails
 * @version 3.5.0
 */

that get changed to this...

 * @see https://docs.woocommerce.com/document/template-structure/
 * @package WooCommerce/Templates/Emails
 * @version 3.5.4
 */

Should I be changing that line as well in the CC revision that is based on the WC PR?

nylen commented 2 years ago

We shouldn't change the main WC version number that CC reports, unless a new version of CC has all of the changes from that version of Woo.

It looks like these are version numbers that appear in each file, which in my opinion is a bit silly to have at all, but I guess the same rule applies: if a given file would include all of the changes from the newer version of Woo, then sure, bump the version number for that file.

Most of the time this would not be the case, so I would default to leaving these alone.

ghost commented 2 years ago

OK, thanks. Leaving them alone was my initial approach, so happy to continue with that. They are really minor changes so it didn't seem that important.